docs: Revert api/envoy/service/auth/v2 CheckResponse.status change#6821
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom May 7, 2019
LukeShu:lukeshu/update-extauth-docs
Merged
docs: Revert api/envoy/service/auth/v2 CheckResponse.status change#6821alyssawilk merged 1 commit intoenvoyproxy:masterfrom LukeShu:lukeshu/update-extauth-docs
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
LukeShu:lukeshu/update-extauth-docs
Conversation
PR #6211 updated the documentation of CheckResponse.status to reflect Envoy's actual behavior at the time. Later, PR #6505 changed that behavior to be in-line with the pre-6211 docs. So, revert that part of PR #6211. This partially reverts commit 0ac3706. Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
alyssawilk
approved these changes
May 7, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Thanks for keeping the docs in line with the code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: PR #6211 updated the documentation of
CheckResponse.statusto reflect Envoy's actual behavior at the time. Later, PR #6505 changed that behavior to be in-line with the pre-6211 docs. So, revert that part of PR #6211.Risk Level: Low
Testing: None
Docs Changes: Inline in API protos
Release Notes: None?